Glasgow | Jan-26 | Elisabeth Matulian | Sprint 2 |Book library debugging#393
Closed
Elisabeth-Matulian wants to merge 9 commits into
Closed
Glasgow | Jan-26 | Elisabeth Matulian | Sprint 2 |Book library debugging#393Elisabeth-Matulian wants to merge 9 commits into
Elisabeth-Matulian wants to merge 9 commits into
Conversation
Elisabeth-Matulian
added
the
Needs Review
cjyuan
reviewed
Apr 2, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
Elisabeth-Matulian
added
the
Needs Review
cjyuan
reviewed
Apr 4, 2026
cjyuan
removed
the
Needs Review
Elisabeth-Matulian
added
the
Needs Review
cjyuan
reviewed
Apr 5, 2026
Comment on lines
+33
to
+35
| inputPages.value.trim() == "" || | ||
| Number(inputPages.value) <= 0 || | ||
| Number(inputPages.value) > 5000 |
Contributor
There was a problem hiding this comment.
-
Why not save the convert page count in a variable first?
-
Besides number range, have you also considered the number type for page count?
Author
There was a problem hiding this comment.
Updated. I actually thought about storing the value in a variable, but I wasn’t sure because the piece of code didn’t seem to be used that much :)
cjyuan
removed
the
Needs Review
Elisabeth-Matulian
added
the
Needs Review
Contributor
|
Changes are good. Well done. |
cjyuan
added
Complete
9 tasks
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
fix:
-add missing bracket in for-loop
-correct variable names
-author field
-event typo
-read status value
-add page title to HTML head
Questions
N/Q